Zero-initialize Matrix values by default#177
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
=======================================
Coverage 94.15% 94.15%
=======================================
Files 92 92
Lines 9524 9529 +5
=======================================
+ Hits 8967 8972 +5
Misses 557 557 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
include/ExtrapolatedSmoother/ExtrapolatedSmootherGive/extrapolatedSmootherGive.h
Show resolved
Hide resolved
EmilyBourne
left a comment
There was a problem hiding this comment.
This looks ok to me. Although I don't know if there is an advantage to zero-initialising the matrices in release mode?
|
The advantage is that we eliminate this big chunk of code in the buildAsc Give. https://github.com/SciCompMod/GMGPolar/blob/main/src/Smoother/SmootherGive/buildMatrix.cpp#L669-#L730 |
Ah! That makes sense. In which case I agree with this PR 👍 |
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):